]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
Fix resource warning when looking at turtledemo’s help (#12295)
authorÉric Araujo <merwok@netwok.org>
Mon, 1 Aug 2011 15:29:36 +0000 (17:29 +0200)
committerÉric Araujo <merwok@netwok.org>
Mon, 1 Aug 2011 15:29:36 +0000 (17:29 +0200)
Lib/idlelib/textView.py

index e5c551ad83a689e52777c1267f878106b7f1750b..e0f49d4c45050511d240ddf236dae7608cf9023c 100644 (file)
@@ -62,14 +62,15 @@ def view_text(parent, title, text):
 
 def view_file(parent, title, filename, encoding=None):
     try:
-        textFile = open(filename, 'r', encoding=encoding)
+        with open(filename, 'r', encoding=encoding) as file:
+            contents = file.read()
     except IOError:
         import tkinter.messagebox as tkMessageBox
         tkMessageBox.showerror(title='File Load Error',
                                message='Unable to load file %r .' % filename,
                                parent=parent)
     else:
-        return view_text(parent, title, textFile.read())
+        return view_text(parent, title, contents)
 
 
 if __name__ == '__main__':