]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
pinctrl: airoha: fix wrong PHY LED mux value for LED1 GPIO46
authorChristian Marangi <ansuelsmth@gmail.com>
Mon, 8 Sep 2025 11:34:24 +0000 (13:34 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Oct 2025 11:48:37 +0000 (13:48 +0200)
commit 6f9674aa69ad0178ca8fc6995942ba9848c324f4 upstream.

In all the MUX value for LED1 GPIO46 there is a Copy-Paste error where
the MUX value is set to LED0_MODE_MASK instead of LED1_MODE_MASK.

This wasn't notice as there were no board that made use of the
secondary PHY LED but looking at the internal Documentation the actual
value should be LED1_MODE_MASK similar to the other GPIO entry.

Fix the wrong value to apply the correct MUX configuration.

Cc: stable@vger.kernel.org
Fixes: 1c8ace2d0725 ("pinctrl: airoha: Add support for EN7581 SoC")
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/pinctrl/mediatek/pinctrl-airoha.c

index 3fa5131d81e525079ac75f32d6b6e46247a5f19f..59381e781be36842b51fd0c4dd94a8c51848ef83 100644 (file)
@@ -1752,8 +1752,8 @@ static const struct airoha_pinctrl_func_group phy1_led1_func_group[] = {
                .regmap[0] = {
                        AIROHA_FUNC_MUX,
                        REG_GPIO_2ND_I2C_MODE,
-                       GPIO_LAN3_LED0_MODE_MASK,
-                       GPIO_LAN3_LED0_MODE_MASK
+                       GPIO_LAN3_LED1_MODE_MASK,
+                       GPIO_LAN3_LED1_MODE_MASK
                },
                .regmap[1] = {
                        AIROHA_FUNC_MUX,
@@ -1816,8 +1816,8 @@ static const struct airoha_pinctrl_func_group phy2_led1_func_group[] = {
                .regmap[0] = {
                        AIROHA_FUNC_MUX,
                        REG_GPIO_2ND_I2C_MODE,
-                       GPIO_LAN3_LED0_MODE_MASK,
-                       GPIO_LAN3_LED0_MODE_MASK
+                       GPIO_LAN3_LED1_MODE_MASK,
+                       GPIO_LAN3_LED1_MODE_MASK
                },
                .regmap[1] = {
                        AIROHA_FUNC_MUX,
@@ -1880,8 +1880,8 @@ static const struct airoha_pinctrl_func_group phy3_led1_func_group[] = {
                .regmap[0] = {
                        AIROHA_FUNC_MUX,
                        REG_GPIO_2ND_I2C_MODE,
-                       GPIO_LAN3_LED0_MODE_MASK,
-                       GPIO_LAN3_LED0_MODE_MASK
+                       GPIO_LAN3_LED1_MODE_MASK,
+                       GPIO_LAN3_LED1_MODE_MASK
                },
                .regmap[1] = {
                        AIROHA_FUNC_MUX,
@@ -1944,8 +1944,8 @@ static const struct airoha_pinctrl_func_group phy4_led1_func_group[] = {
                .regmap[0] = {
                        AIROHA_FUNC_MUX,
                        REG_GPIO_2ND_I2C_MODE,
-                       GPIO_LAN3_LED0_MODE_MASK,
-                       GPIO_LAN3_LED0_MODE_MASK
+                       GPIO_LAN3_LED1_MODE_MASK,
+                       GPIO_LAN3_LED1_MODE_MASK
                },
                .regmap[1] = {
                        AIROHA_FUNC_MUX,