]> git.ipfire.org Git - thirdparty/openvpn.git/commitdiff
test_packet_id: Add a check after malloc to ensure value is valid
authorFrank Lichtenheld <frank@lichtenheld.com>
Mon, 6 Apr 2026 07:47:24 +0000 (09:47 +0200)
committerGert Doering <gert@greenie.muc.de>
Mon, 6 Apr 2026 10:00:30 +0000 (12:00 +0200)
cppcheck complains about a potential null pointer dereference
in reliable_get_num_output_sequenced_available. That is mostly
theoretical, but still add a check.

Change-Id: I64da2328591ef2b9ee7502e574c878651cdf356a
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1621
Message-Id: <20260406074729.29903-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36516.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
tests/unit_tests/openvpn/test_packet_id.c

index b7538bd5fd9b24f9d55d85c85f2b47c3c6b79497..5dfd319ab9aee6a2383fe3f2bf0141957d77b430 100644 (file)
@@ -164,6 +164,7 @@ static void
 test_get_num_output_sequenced_available(void **state)
 {
     struct reliable *rel = malloc(sizeof(struct reliable));
+    assert_non_null(rel);
     reliable_init(rel, 100, 50, 8, false);
 
     rel->array[5].active = true;