]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: sparx5: move remaining init functions from start() to probe()
authorDaniel Machon <daniel.machon@microchip.com>
Fri, 27 Feb 2026 14:56:44 +0000 (15:56 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 3 Mar 2026 02:46:21 +0000 (18:46 -0800)
Move sparx5_pgid_init(), sparx5_vlan_init(), and sparx5_board_init()
from sparx5_start() to probe(). These functions do not require cleanup.

Signed-off-by: Daniel Machon <daniel.machon@microchip.com>
Link: https://patch.msgid.link/20260227-sparx5-init-deinit-v2-6-10ba54ccf005@microchip.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/microchip/sparx5/sparx5_main.c

index 46ddd7a5fb61a88224341e8783e110fd0d33ef76..c2f8a6635715e310413221b08c76821e25eaaf6c 100644 (file)
@@ -726,17 +726,9 @@ static int sparx5_start(struct sparx5 *sparx5)
                         ANA_CL_FILTER_CTRL_FORCE_FCS_UPDATE_ENA,
                         sparx5, ANA_CL_FILTER_CTRL(idx));
 
-       /* Init PGID table arbitrator */
-       sparx5_pgid_init(sparx5);
-
-       /* Setup VLANs */
-       sparx5_vlan_init(sparx5);
-
        /* Enable queue limitation watermarks */
        sparx5_qlim_set(sparx5);
 
-       sparx5_board_init(sparx5);
-
        /* Start Frame DMA with fallback to register based INJ/XTR */
        err = -ENXIO;
        if (sparx5->fdma_irq >= 0) {
@@ -942,6 +934,10 @@ static int mchp_sparx5_probe(struct platform_device *pdev)
                }
        }
 
+       sparx5_pgid_init(sparx5);
+       sparx5_vlan_init(sparx5);
+       sparx5_board_init(sparx5);
+
        err = sparx5_start(sparx5);
        if (err) {
                dev_err(sparx5->dev, "Start failed\n");