]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
tools/sched_ext: Remove dead -d option in scx_flatcg
authorCheng-Yang Chou <yphbchou0911@gmail.com>
Sun, 19 Apr 2026 16:36:13 +0000 (00:36 +0800)
committerTejun Heo <tj@kernel.org>
Mon, 20 Apr 2026 16:54:44 +0000 (06:54 -1000)
The -d option was non-functional, only toggling a variable that was
echoed in the status line but never used to dump the cgroup hierarchy.
Remove the option to avoid documenting dead code as a feature.

Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Cheng-Yang Chou <yphbchou0911@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
tools/sched_ext/scx_flatcg.c

index d865c381589bbf66fbc00d41715ef3d53f240e6c..de2bef86d64d628ddc02083eb87fe87aaca263ab 100644 (file)
@@ -130,7 +130,6 @@ int main(int argc, char **argv)
        struct scx_flatcg *skel;
        struct bpf_link *link;
        struct timespec intv_ts = { .tv_sec = 2, .tv_nsec = 0 };
-       bool dump_cgrps = false;
        __u64 last_cpu_sum = 0, last_cpu_idle = 0;
        __u64 last_stats[FCG_NR_STATS] = {};
        unsigned long seq = 0;
@@ -148,7 +147,7 @@ restart:
        assert(skel->rodata->nr_cpus > 0);
        skel->rodata->cgrp_slice_ns = __COMPAT_ENUM_OR_ZERO("scx_public_consts", "SCX_SLICE_DFL");
 
-       while ((opt = getopt(argc, argv, "s:i:dfvh")) != -1) {
+       while ((opt = getopt(argc, argv, "s:i:fvh")) != -1) {
                double v;
 
                switch (opt) {
@@ -161,9 +160,6 @@ restart:
                        intv_ts.tv_sec = v;
                        intv_ts.tv_nsec = (v - (float)intv_ts.tv_sec) * 1000000000;
                        break;
-               case 'd':
-                       dump_cgrps = true;
-                       break;
                case 'f':
                        skel->rodata->fifo_sched = true;
                        break;
@@ -177,10 +173,10 @@ restart:
                }
        }
 
-       printf("slice=%.1lfms intv=%.1lfs dump_cgrps=%d",
+       printf("slice=%.1lfms intv=%.1lfs",
               (double)skel->rodata->cgrp_slice_ns / 1000000.0,
-              (double)intv_ts.tv_sec + (double)intv_ts.tv_nsec / 1000000000.0,
-              dump_cgrps);
+              (double)intv_ts.tv_sec + (double)intv_ts.tv_nsec / 1000000000.0);
+
 
        SCX_OPS_LOAD(skel, flatcg_ops, scx_flatcg, uei);
        link = SCX_OPS_ATTACH(skel, flatcg_ops, scx_flatcg);