]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
selftest: Report "unknown environment" if setup returns "UNKNOWN"
authorSATOH Fumiyasu <fumiyas@osstech.co.jp>
Sat, 13 May 2023 13:30:04 +0000 (22:30 +0900)
committerAndrew Bartlett <abartlet@samba.org>
Fri, 19 May 2023 00:29:33 +0000 (00:29 +0000)
Samba*::setup_*() may return the string "UNKNOWN".

```
$ ./configure --with-ads ...
...
$ make
...
$ make test
...
Can't use string ("UNKNOWN") as a HASH ref while "strict refs" in use at /.../samba-4.18.2/selftest/target/Samba.pm line 131.
```

Signed-off-by: SATOH Fumiyasu <fumiyas@osstech.co.jp>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Joseph Sutton <josephsutton@catalyst.net.nz>
selftest/target/Samba.pm

index 4f0f29df5cf99e4cc12d0e1a6cf64c831069024e..29a612aab8b2356de258ac0060e05d5113569cf9 100644 (file)
@@ -127,6 +127,10 @@ sub setup_env($$$)
                warn("failed to start up environment '$envname'");
                return undef;
        }
+       if ($env eq "UNKNOWN") {
+               warn("unknown environment '$envname'");
+               return undef;
+       }
 
        $target->{vars}->{$envname} = $env;
        $target->{vars}->{$envname}->{target} = $target;