Issue #16601: Restarting iteration over tarfile no more continues from where

it left off.  Patch by Michael Birtwell.

diff --git a/Lib/tarfile.py b/Lib/tarfile.py
index 89d8cc3ffd5d9122a6d0ab11bbf363b98c723e45..16a6e86dce1cd0264b1382b7e31c2a0e823bcc17 100644 (file)
--- a/Lib/tarfile.py
+++ b/Lib/tarfile.py
@@ -2462,16 +2462,18 @@ class TarIter:
         # Fix for SF #1100429: Under rare circumstances it can
         # happen that getmembers() is called during iteration,
         # which will cause TarIter to stop prematurely.
-        if not self.tarfile._loaded:
+
+        if self.index == 0 and self.tarfile.firstmember is not None:
+            tarinfo = self.tarfile.next()
+        elif self.index < len(self.tarfile.members):
+            tarinfo = self.tarfile.members[self.index]
+        elif not self.tarfile._loaded:
             tarinfo = self.tarfile.next()
             if not tarinfo:
                 self.tarfile._loaded = True
                 raise StopIteration
         else:
-            try:
-                tarinfo = self.tarfile.members[self.index]
-            except IndexError:
-                raise StopIteration
+            raise StopIteration
         self.index += 1
         return tarinfo
 

diff --git a/Lib/test/test_tarfile.py b/Lib/test/test_tarfile.py
index af59e277f3e40ac3cd2870e7096bd573a7cbd351..69d342a5031d7e951b4cb0920179b83c95ba338d 100644 (file)
--- a/Lib/test/test_tarfile.py
+++ b/Lib/test/test_tarfile.py
@@ -345,6 +345,14 @@ class MiscReadTest(CommonReadTest):
         finally:
             os.remove(empty)
 
+    def test_parallel_iteration(self):
+        # Issue #16601: Restarting iteration over tarfile continued
+        # from where it left off.
+        with tarfile.open(self.tarname) as tar:
+            for m1, m2 in zip(tar, tar):
+                self.assertEqual(m1.offset, m2.offset)
+                self.assertEqual(m1.name, m2.name)
+
 
 class StreamReadTest(CommonReadTest):
 

diff --git a/Misc/ACKS b/Misc/ACKS
index 9e09abdf78acb21716ea191e1a1ead176fb2fcd2..7f78dbdeb7b647b65f3a852a46fae8991f9f0b78 100644 (file)
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -96,6 +96,7 @@ Natalia B. Bidart
 David Binger
 Dominic Binks
 Philippe Biondi
+Michael Birtwell
 Stuart Bishop
 Roy Bixler
 Jonathan Black

diff --git a/Misc/NEWS b/Misc/NEWS
index 6eea7de41820a3daea2aa5893b734e8168b6ee12..2c094208c63cc2129890109a607442aade91a489 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -26,6 +26,9 @@ Core and Builtins
 Library
 -------
 
+- Issue #16601: Restarting iteration over tarfile no more continues from where
+  it left off.  Patch by Michael Birtwell.
+
 - Issue 16584: in filecomp._cmp, catch IOError as well as os.error.
   Patch by Till Maas.