[3.15] gh-152951 - Fix double DECREF when `newblock` fails during deque.extend calls...

gh-152951 - Fix double DECREF when `newblock` fails during deque.extend calls (GH-152961)
(cherry picked from commit a90576d72c8a409f7c3ffcaefafb13945e3405ab)

Co-authored-by: Steve Stagg <stestagg@gmail.com>

diff --git a/Misc/NEWS.d/next/Library/2026-07-03-14-54-33.gh-issue-152951.u8tPCI.rst b/Misc/NEWS.d/next/Library/2026-07-03-14-54-33.gh-issue-152951.u8tPCI.rst
new file mode 100644 (file)
index 0000000..c3d56c6
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2026-07-03-14-54-33.gh-issue-152951.u8tPCI.rst
@@ -0,0 +1,2 @@
+:class:`collections.deque` prevent rare crash when calling ``extend`` under
+high memory pressure conditions.

diff --git a/Modules/_collectionsmodule.c b/Modules/_collectionsmodule.c
index 5ca6362406a78b9c57227fe5784cf4de7d9190d5..b0701df26bbd24cafd734e991529819e8e98447b 100644 (file)
--- a/Modules/_collectionsmodule.c
+++ b/Modules/_collectionsmodule.c
@@ -512,7 +512,6 @@ deque_extend_impl(dequeobject *deque, PyObject *iterable)
     iternext = *Py_TYPE(it)->tp_iternext;
     while ((item = iternext(it)) != NULL) {
         if (deque_append_lock_held(deque, item, maxlen) == -1) {
-            Py_DECREF(item);
             Py_DECREF(it);
             return NULL;
         }