]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/amd/display: Fix the checking condition in dmub aux handling
authorWayne Lin <Wayne.Lin@amd.com>
Sun, 20 Apr 2025 08:29:07 +0000 (16:29 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 18 May 2025 06:24:07 +0000 (08:24 +0200)
commit bc70e11b550d37fbd9eaed0f113ba560894f1609 upstream.

[Why & How]
Fix the checking condition for detecting AUX_RET_ERROR_PROTOCOL_ERROR.
It was wrongly checking by "not equals to"

Reviewed-by: Ray Wu <ray.wu@amd.com>
Signed-off-by: Wayne Lin <Wayne.Lin@amd.com>
Signed-off-by: Ray Wu <ray.wu@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry picked from commit 1db6c9e9b62e1a8912f0a281c941099fca678da3)
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

index dd643563a5e8d1b44cc4c94c0da7af039b6b8b77..a0bd970c09b46e0214ffe9578b0391627a67c369 100644 (file)
@@ -11055,7 +11055,7 @@ int amdgpu_dm_process_dmub_aux_transfer_sync(
                 * Transient states before tunneling is enabled could
                 * lead to this error. We can ignore this for now.
                 */
-               if (p_notify->result != AUX_RET_ERROR_PROTOCOL_ERROR) {
+               if (p_notify->result == AUX_RET_ERROR_PROTOCOL_ERROR) {
                        DRM_WARN("DPIA AUX failed on 0x%x(%d), error %d\n",
                                        payload->address, payload->length,
                                        p_notify->result);