]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-109195: fix source location for super load before LOAD_SUPER_ATTR (#109289)
authorCarl Meyer <carl@oddbird.net>
Mon, 11 Sep 2023 23:35:49 +0000 (17:35 -0600)
committerGitHub <noreply@github.com>
Mon, 11 Sep 2023 23:35:49 +0000 (17:35 -0600)
Lib/test/test_compile.py
Misc/NEWS.d/next/Core and Builtins/2023-09-11-15-51-55.gh-issue-109195.iwxmuo.rst [new file with mode: 0644]
Python/compile.c

index 28b2c4686bbc89550c91e2817ea864ff7abb4831..a8a519f573e663f9dd7596f7c800c557f540114a 100644 (file)
@@ -1751,6 +1751,13 @@ class TestSourcePositions(unittest.TestCase):
                     list(code.co_consts[1].co_positions()),
                 )
 
+    def test_load_super_attr(self):
+        source = "class C:\n  def __init__(self):\n    super().__init__()"
+        code = compile(source, "<test>", "exec").co_consts[0].co_consts[1]
+        self.assertOpcodeSourcePositionIs(
+            code, "LOAD_GLOBAL", line=3, end_line=3, column=4, end_column=9
+        )
+
 
 class TestExpressionStackSize(unittest.TestCase):
     # These tests check that the computed stack size for a code object
diff --git a/Misc/NEWS.d/next/Core and Builtins/2023-09-11-15-51-55.gh-issue-109195.iwxmuo.rst b/Misc/NEWS.d/next/Core and Builtins/2023-09-11-15-51-55.gh-issue-109195.iwxmuo.rst
new file mode 100644 (file)
index 0000000..5427232
--- /dev/null
@@ -0,0 +1,4 @@
+Fix source location for the ``LOAD_*`` instruction preceding a
+``LOAD_SUPER_ATTR`` to load the ``super`` global (or shadowing variable) so
+that it encompasses only the name ``super`` and not the following
+parentheses.
index ae9edc90ea436762839c199fa16b3b408dfc9d6a..1f08e46023e15acb72e3f692657de8b990073dee 100644 (file)
@@ -4868,7 +4868,7 @@ load_args_for_super(struct compiler *c, expr_ty e) {
 
     // load super() global
     PyObject *super_name = e->v.Call.func->v.Name.id;
-    RETURN_IF_ERROR(compiler_nameop(c, loc, super_name, Load));
+    RETURN_IF_ERROR(compiler_nameop(c, LOC(e->v.Call.func), super_name, Load));
 
     if (asdl_seq_LEN(e->v.Call.args) == 2) {
         VISIT(c, expr, asdl_seq_GET(e->v.Call.args, 0));