]> git.ipfire.org Git - dbl.git/commitdiff
api: Send 409 if someone is trying to close a closed report
authorMichael Tremer <michael.tremer@ipfire.org>
Tue, 3 Mar 2026 11:33:31 +0000 (11:33 +0000)
committerMichael Tremer <michael.tremer@ipfire.org>
Tue, 3 Mar 2026 11:33:31 +0000 (11:33 +0000)
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
src/dbl/api/reports.py

index cc62350dccd66d40e6422bcd26b420f6a72445b1..27940e2b55682fc939d971c286ccb07207d9f960 100644 (file)
@@ -109,6 +109,10 @@ async def close_report(
                report: reports.Report = fastapi.Depends(get_report_from_path),
                user: users.User = fastapi.Depends(require_current_user),
 ) -> fastapi.Response:
+       # Fail if the report has already been closed
+       if report.is_closed():
+               raise fastapi.HTTPException(409, "The report is already closed")
+
        # Check for permissions
        if not await report.has_perm(user, accept=data.accept):
                raise fastapi.HTTPError(403, "You don't have permission to change this report")