]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
flow: overwrite p::flowflags on first set
authorVictor Julien <victor@inliniac.net>
Mon, 2 Feb 2015 14:46:24 +0000 (15:46 +0100)
committerVictor Julien <victor@inliniac.net>
Wed, 18 Feb 2015 08:18:43 +0000 (09:18 +0100)
src/flow.c

index 2e374592045dacca40e669e5a866b1d85deb506c..cdeb569226d5003230cddfcf065b01208ae53b2b 100644 (file)
@@ -232,6 +232,8 @@ static inline int FlowUpdateSeenFlag(const Packet *p)
  *
  *  \param f locked flow
  *  \param p packet
+ *
+ *  \note overwrites p::flowflags
  */
 void FlowHandlePacketUpdate(Flow *f, Packet *p)
 {
@@ -247,14 +249,14 @@ void FlowHandlePacketUpdate(Flow *f, Packet *p)
         }
         f->todstpktcnt++;
         f->todstbytecnt += GET_PKT_LEN(p);
-        p->flowflags |= FLOW_PKT_TOSERVER;
+        p->flowflags = FLOW_PKT_TOSERVER;
     } else {
         if (FlowUpdateSeenFlag(p)) {
             f->flags |= FLOW_TO_SRC_SEEN;
         }
         f->tosrcpktcnt++;
         f->tosrcbytecnt += GET_PKT_LEN(p);
-        p->flowflags |= FLOW_PKT_TOCLIENT;
+        p->flowflags = FLOW_PKT_TOCLIENT;
     }
 
     if ((f->flags & (FLOW_TO_DST_SEEN|FLOW_TO_SRC_SEEN)) == (FLOW_TO_DST_SEEN|FLOW_TO_SRC_SEEN)) {