]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
Added kw_only parameter to make_dataclasses. (GH-29679)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Sat, 20 Nov 2021 23:46:56 +0000 (15:46 -0800)
committerGitHub <noreply@github.com>
Sat, 20 Nov 2021 23:46:56 +0000 (15:46 -0800)
(cherry picked from commit f7638dd0f90b2afd9295ee179119f4a29859953a)

Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
Lib/dataclasses.py
Lib/test/test_dataclasses.py
Misc/NEWS.d/next/Library/2021-11-20-17-04-25.bpo-45803.wSgFOy.rst [new file with mode: 0644]

index aa84f1b9533cb94cfefcaa6101a872cbf4f1fa52..4f4aa3d3487ce897054d6fbc6b1c9f10412c1864 100644 (file)
@@ -1326,7 +1326,7 @@ def _astuple_inner(obj, tuple_factory):
 
 def make_dataclass(cls_name, fields, *, bases=(), namespace=None, init=True,
                    repr=True, eq=True, order=False, unsafe_hash=False,
-                   frozen=False, match_args=True, slots=False):
+                   frozen=False, match_args=True, kw_only=False, slots=False):
     """Return a new dynamically created dataclass.
 
     The dataclass name will be 'cls_name'.  'fields' is an iterable
@@ -1393,7 +1393,7 @@ def make_dataclass(cls_name, fields, *, bases=(), namespace=None, init=True,
     # Apply the normal decorator.
     return dataclass(cls, init=init, repr=repr, eq=eq, order=order,
                      unsafe_hash=unsafe_hash, frozen=frozen,
-                     match_args=match_args, slots=slots)
+                     match_args=match_args, kw_only=kw_only, slots=slots)
 
 
 def replace(obj, /, **changes):
index bbbb8e6c6395b8f992ebad0f8f5583c711c6d297..b00d0484d387ea06b3dc7e3736f5e1842b6ac3c4 100644 (file)
@@ -3864,5 +3864,16 @@ class TestKeywordArgs(unittest.TestCase):
                 c: int = 1
                 d: int
 
+    def test_make_dataclass(self):
+        A = make_dataclass("A", ['a'], kw_only=True)
+        self.assertTrue(fields(A)[0].kw_only)
+
+        B = make_dataclass("B",
+                           ['a', ('b', int, field(kw_only=False))],
+                           kw_only=True)
+        self.assertTrue(fields(B)[0].kw_only)
+        self.assertFalse(fields(B)[1].kw_only)
+
+
 if __name__ == '__main__':
     unittest.main()
diff --git a/Misc/NEWS.d/next/Library/2021-11-20-17-04-25.bpo-45803.wSgFOy.rst b/Misc/NEWS.d/next/Library/2021-11-20-17-04-25.bpo-45803.wSgFOy.rst
new file mode 100644 (file)
index 0000000..77479d7
--- /dev/null
@@ -0,0 +1 @@
+Added missing kw_only parameter to dataclasses.make_dataclass().