]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
sparc: serial: sunhv: fix a double lock bug
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 15 Jul 2016 11:17:33 +0000 (14:17 +0300)
committerBen Hutchings <ben@decadent.org.uk>
Sun, 20 Nov 2016 01:16:59 +0000 (01:16 +0000)
commit 344e3c7734d5090b148c19ac6539b8947fed6767 upstream.

We accidentally take the "port->lock" twice in a row.  This old code
was supposed to be deleted.

Fixes: e58e241c1788 ('sparc: serial: Clean up the locking for -rt')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/tty/serial/sunhv.c

index dc697cee248ad3dcfa84e2f1d66f8c439b37dd81..233103adad2d7ea42ad58f98b4735b472ec01b86 100644 (file)
@@ -492,12 +492,6 @@ static void sunhv_console_write_bychar(struct console *con, const char *s, unsig
                locked = spin_trylock_irqsave(&port->lock, flags);
        else
                spin_lock_irqsave(&port->lock, flags);
-       if (port->sysrq) {
-               locked = 0;
-       } else if (oops_in_progress) {
-               locked = spin_trylock(&port->lock);
-       } else
-               spin_lock(&port->lock);
 
        for (i = 0; i < n; i++) {
                if (*s == '\n')