re PR c++/59821 (__builtin_LINE and __builtin_FILE for new'd objects is wrong)

	PR c++/59821
	* tree.c (bot_manip): Update the location of builtin_LINE and
	builtin_FILE calls.

From-SVN: r206686

diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index c15c8fd511c501b2b80807d011f6ccc6520641ae..848c406ecf4d86d30837f0b91b01c548c60c444f 100644 (file)
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,3 +1,9 @@
+2014-01-16  Jason Merrill  <jason@redhat.com>
+
+       PR c++/59821
+       * tree.c (bot_manip): Update the location of builtin_LINE and
+       builtin_FILE calls.
+
 2014-01-14  Jason Merrill  <jason@redhat.com>
 
        PR c++/59659

diff --git a/gcc/cp/tree.c b/gcc/cp/tree.c
index 7aad1eb9bd4f9c1f4337026020e40c5a107cdf90..ce41c3b1930277b44bab7c2ee49d1b14272c3a80 100644 (file)
--- a/gcc/cp/tree.c
+++ b/gcc/cp/tree.c
@@ -2306,7 +2306,20 @@ bot_manip (tree* tp, int* walk_subtrees, void* data)
   /* Make a copy of this node.  */
   t = copy_tree_r (tp, walk_subtrees, NULL);
   if (TREE_CODE (*tp) == CALL_EXPR)
-    set_flags_from_callee (*tp);
+    {
+      set_flags_from_callee (*tp);
+
+      /* builtin_LINE and builtin_FILE get the location where the default
+        argument is expanded, not where the call was written.  */
+      tree callee = get_callee_fndecl (*tp);
+      if (callee && DECL_BUILT_IN (callee))
+       switch (DECL_FUNCTION_CODE (callee))
+         {
+         case BUILT_IN_FILE:
+         case BUILT_IN_LINE:
+           SET_EXPR_LOCATION (*tp, input_location);
+         }
+    }
   return t;
 }
 

diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi
index 84fd594b605563499ea8e19d26e27c2a0770b194..2f4f91d233aca4c813759f08be88e29afd4ed85b 100644 (file)
--- a/gcc/doc/extend.texi
+++ b/gcc/doc/extend.texi
@@ -8726,6 +8726,8 @@ means that the compiler can assume for @code{x}, set to @code{arg}, that
 @deftypefn {Built-in Function} int __builtin_LINE ()
 This function is the equivalent to the preprocessor @code{__LINE__}
 macro and returns the line number of the invocation of the built-in.
+In a C++ default argument for a function @var{F}, it gets the line number of
+the call to @var{F}.
 @end deftypefn
 
 @deftypefn {Built-in Function} {const char *} __builtin_FUNCTION ()
@@ -8736,6 +8738,8 @@ macro and returns the function name the invocation of the built-in is in.
 @deftypefn {Built-in Function} {const char *} __builtin_FILE ()
 This function is the equivalent to the preprocessor @code{__FILE__}
 macro and returns the file name the invocation of the built-in is in.
+In a C++ default argument for a function @var{F}, it gets the file name of
+the call to @var{F}.
 @end deftypefn
 
 @deftypefn {Built-in Function} void __builtin___clear_cache (char *@var{begin}, char *@var{end})

diff --git a/gcc/testsuite/g++.dg/ext/builtin-line1.C b/gcc/testsuite/g++.dg/ext/builtin-line1.C
new file mode 100644 (file)
index 0000000..21a4f59
--- /dev/null
+++ b/gcc/testsuite/g++.dg/ext/builtin-line1.C
@@ -0,0 +1,17 @@
+// __builtin_LINE gets the location where the default argument is expanded.
+// { dg-do run }
+
+#include <cassert>
+struct Foo
+{
+  int line;
+  Foo( int line = __builtin_LINE() )
+    : line( line )
+  {}
+};
+
+int main()
+{
+  assert (Foo().line == __LINE__);
+  assert ((new Foo)->line == __LINE__);
+}