]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
bpo-44991: Normalise function and collation callback naming (GH-28209)
authorErlend Egeberg Aasland <erlend.aasland@innova.no>
Tue, 12 Oct 2021 11:38:49 +0000 (13:38 +0200)
committerGitHub <noreply@github.com>
Tue, 12 Oct 2021 11:38:49 +0000 (13:38 +0200)
Modules/_sqlite/connection.c

index b4badb111a3c7722a18b23a65c41fa43bbc79926..d6d1fa8bf28761d0437c584988bffdd5f72741f7 100644 (file)
@@ -667,7 +667,7 @@ set_sqlite_error(sqlite3_context *context, const char *msg)
 }
 
 static void
-_pysqlite_func_callback(sqlite3_context *context, int argc, sqlite3_value **argv)
+func_callback(sqlite3_context *context, int argc, sqlite3_value **argv)
 {
     PyGILState_STATE threadstate = PyGILState_Ensure();
 
@@ -908,7 +908,7 @@ pysqlite_connection_create_function_impl(pysqlite_Connection *self,
         return NULL;
     }
     rc = sqlite3_create_function_v2(self->db, name, narg, flags, ctx,
-                                    _pysqlite_func_callback,
+                                    func_callback,
                                     NULL,
                                     NULL,
                                     &destructor_callback);  // will decref func
@@ -1501,10 +1501,8 @@ error:
 /* ------------------------- COLLATION CODE ------------------------ */
 
 static int
-pysqlite_collation_callback(
-        void* context,
-        int text1_length, const void* text1_data,
-        int text2_length, const void* text2_data)
+collation_callback(void *context, int text1_length, const void *text1_data,
+                   int text2_length, const void *text2_data)
 {
     PyGILState_STATE gilstate = PyGILState_Ensure();
 
@@ -1778,7 +1776,7 @@ pysqlite_connection_create_collation_impl(pysqlite_Connection *self,
             return NULL;
         }
         rc = sqlite3_create_collation_v2(self->db, name, flags, ctx,
-                                         &pysqlite_collation_callback,
+                                         &collation_callback,
                                          &destructor_callback);
     }