]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4/messaging/py: Fix leak
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Tue, 23 May 2023 00:46:56 +0000 (12:46 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Wed, 24 May 2023 00:50:31 +0000 (00:50 +0000)
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/lib/messaging/pymessaging.c

index 5235d84f8e8c5e5a60d5bc6f56963d4cb8f7e913..5dd5839b629562e2322759900a219c398f5ab609 100644 (file)
@@ -195,13 +195,14 @@ static void py_msg_callback_wrapper(struct imessaging_context *msg,
        PyObject *py_server_id, *callback_and_tuple = (PyObject *)private_data;
        PyObject *callback, *py_private;
 
-       struct server_id *p_server_id = talloc(NULL, struct server_id);
+       struct server_id *p_server_id = NULL;
 
        if (num_fds != 0) {
                DBG_WARNING("Received %zu fds, ignoring message\n", num_fds);
                return;
        }
 
+       p_server_id = talloc(NULL, struct server_id);
        if (!p_server_id) {
                PyErr_NoMemory();
                return;