netrom: Fix a data-race around sysctl_netrom_link_fails_count

[ Upstream commit bc76645ebdd01be9b9994dac39685a3d0f6f7985 ]

We need to protect the reader reading the sysctl value because the
value can be changed concurrently.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Jason Xing <kernelxing@tencent.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/net/netrom/nr_route.c b/net/netrom/nr_route.c
index 88c59bd0f739746859a65d016fcedd5127954e92..895702337c92e1d0dddfce0631ca730ff0a1e4fb 100644 (file)
--- a/net/netrom/nr_route.c
+++ b/net/netrom/nr_route.c
@@ -725,7 +725,7 @@ void nr_link_failed(ax25_cb *ax25, int reason)
        nr_neigh->ax25 = NULL;
        ax25_cb_put(ax25);
 
-       if (++nr_neigh->failed < sysctl_netrom_link_fails_count) {
+       if (++nr_neigh->failed < READ_ONCE(sysctl_netrom_link_fails_count)) {
                nr_neigh_put(nr_neigh);
                return;
        }