RDMA/hns: Fixed wrong judgments in the goto branch

[ Upstream commit bb74fe7e81c8b2b65c6a351a247fdb9a969cbaec ]

When an error occurs, the qp_table must be cleared, regardless of whether
the SRQ feature is enabled.

Fixes: 5c1f167af112 ("RDMA/hns: Init SRQ table for hip08")
Link: https://lore.kernel.org/r/1611997090-48820-5-git-send-email-liweihang@huawei.com
Signed-off-by: Wenpeng Liang <liangwenpeng@huawei.com>
Signed-off-by: Weihang Li <liweihang@huawei.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/infiniband/hw/hns/hns_roce_main.c b/drivers/infiniband/hw/hns/hns_roce_main.c
index b5d196c119eec09b5c6b52c8f62d8b384c54d999..f23a341400c06b6127887efbdaf1aa231a54327c 100644 (file)
--- a/drivers/infiniband/hw/hns/hns_roce_main.c
+++ b/drivers/infiniband/hw/hns/hns_roce_main.c
@@ -848,8 +848,7 @@ static int hns_roce_setup_hca(struct hns_roce_dev *hr_dev)
        return 0;
 
 err_qp_table_free:
-       if (hr_dev->caps.flags & HNS_ROCE_CAP_FLAG_SRQ)
-               hns_roce_cleanup_qp_table(hr_dev);
+       hns_roce_cleanup_qp_table(hr_dev);
 
 err_cq_table_free:
        hns_roce_cleanup_cq_table(hr_dev);