]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
spi: microchip-core-spi: fix controller deregistration
authorJohan Hovold <johan@kernel.org>
Thu, 9 Apr 2026 12:04:18 +0000 (14:04 +0200)
committerMark Brown <broonie@kernel.org>
Thu, 9 Apr 2026 19:08:13 +0000 (20:08 +0100)
Make sure to deregister the controller before disabling underlying
resources like interrupts during driver unbind.

Fixes: 059f545832be ("spi: add support for microchip "soft" spi controller")
Cc: stable@vger.kernel.org # 6.19
Cc: Prajna Rajendra Kumar <prajna.rajendrakumar@microchip.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Link: https://patch.msgid.link/20260409120419.388546-20-johan@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-microchip-core-spi.c

index a4c128ae391b5de646bbb0ebab3557c60c04b2e2..be01c178e2b08fe0ac7a232c53c8b6eaba54f306 100644 (file)
@@ -384,7 +384,7 @@ static int mchp_corespi_probe(struct platform_device *pdev)
 
        mchp_corespi_init(host, spi);
 
-       ret = devm_spi_register_controller(dev, host);
+       ret = spi_register_controller(host);
        if (ret) {
                mchp_corespi_disable_ints(spi);
                mchp_corespi_disable(spi);
@@ -399,6 +399,8 @@ static void mchp_corespi_remove(struct platform_device *pdev)
        struct spi_controller *host = platform_get_drvdata(pdev);
        struct mchp_corespi *spi = spi_controller_get_devdata(host);
 
+       spi_unregister_controller(host);
+
        mchp_corespi_disable_ints(spi);
        mchp_corespi_disable(spi);
 }