]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
selftests: netdevsim: Fix ethtool-coalesce.sh fail by installing ethtool-common.sh
authorWang Liang <wangliang74@huawei.com>
Thu, 30 Oct 2025 04:03:40 +0000 (12:03 +0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 1 Nov 2025 00:41:54 +0000 (17:41 -0700)
The script "ethtool-common.sh" is not installed in INSTALL_PATH, and
triggers some errors when I try to run the test
'drivers/net/netdevsim/ethtool-coalesce.sh':

  TAP version 13
  1..1
  # timeout set to 600
  # selftests: drivers/net/netdevsim: ethtool-coalesce.sh
  # ./ethtool-coalesce.sh: line 4: ethtool-common.sh: No such file or directory
  # ./ethtool-coalesce.sh: line 25: make_netdev: command not found
  # ethtool: bad command line argument(s)
  # ./ethtool-coalesce.sh: line 124: check: command not found
  # ./ethtool-coalesce.sh: line 126: [: -eq: unary operator expected
  # FAILED /0 checks
  not ok 1 selftests: drivers/net/netdevsim: ethtool-coalesce.sh # exit=1

Install this file to avoid this error. After this patch:

  TAP version 13
  1..1
  # timeout set to 600
  # selftests: drivers/net/netdevsim: ethtool-coalesce.sh
  # PASSED all 22 checks
  ok 1 selftests: drivers/net/netdevsim: ethtool-coalesce.sh

Fixes: fbb8531e58bd ("selftests: extract common functions in ethtool-common.sh")
Signed-off-by: Wang Liang <wangliang74@huawei.com>
Link: https://patch.msgid.link/20251030040340.3258110-1-wangliang74@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/drivers/net/netdevsim/Makefile

index daf51113c8272e892b45619ba34be92bb1433021..df10c72435119313e887b151977662e7b6de547f 100644 (file)
@@ -20,4 +20,8 @@ TEST_PROGS := \
        udp_tunnel_nic.sh \
 # end of TEST_PROGS
 
+TEST_FILES := \
+       ethtool-common.sh
+# end of TEST_FILES
+
 include ../../../lib.mk