Don't use ast_strdupa() from within the arguments to a function.

(closes issue #17902)
Reported by: afried
Patches:
      issue_17902.rev1.txt uploaded by russell (license 2)
Tested by: russell

Review: https://reviewboard.asterisk.org/r/927/

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@287895 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/channels/chan_sip.c b/channels/chan_sip.c
index a7bda8de69add608aa45889dabef71d2255711c9..2abe3981985c9e77077474348b1c52542726abd8 100644 (file)
--- a/channels/chan_sip.c
+++ b/channels/chan_sip.c
@@ -13837,6 +13837,8 @@ static enum check_auth_result register_verify(struct sip_pvt *p, struct ast_sock
                        /* Wrong password in authentication. Go away, don't try again until you fixed it */
                        transmit_response(p, "403 Forbidden (Bad auth)", &p->initreq);
                        if (global_authfailureevents) {
+                               const char *peer_addr = ast_strdupa(ast_sockaddr_stringify_addr(addr));
+                               const char *peer_port = ast_strdupa(ast_sockaddr_stringify_port(addr));
                                manager_event(EVENT_FLAG_SYSTEM, "PeerStatus",
                                              "ChannelType: SIP\r\n"
                                              "Peer: SIP/%s\r\n"
@@ -13844,8 +13846,7 @@ static enum check_auth_result register_verify(struct sip_pvt *p, struct ast_sock
                                              "Cause: AUTH_SECRET_FAILED\r\n"
                                              "Address: %s\r\n"
                                              "Port: %s\r\n",
-                                             name, ast_strdupa(ast_sockaddr_stringify_addr(addr)),
-                                             ast_strdupa(ast_sockaddr_stringify_port(addr)));
+                                             name, peer_addr, peer_port);
                        }
                        break;
                case AUTH_USERNAME_MISMATCH:
@@ -13859,6 +13860,8 @@ static enum check_auth_result register_verify(struct sip_pvt *p, struct ast_sock
                        if (sip_cfg.alwaysauthreject) {
                                transmit_fake_auth_response(p, SIP_REGISTER, &p->initreq, XMIT_UNRELIABLE);
                                if (global_authfailureevents) {
+                                       const char *peer_addr = ast_strdupa(ast_sockaddr_stringify_addr(addr));
+                                       const char *peer_port = ast_strdupa(ast_sockaddr_stringify_port(addr));
                                        manager_event(EVENT_FLAG_SYSTEM, "PeerStatus",
                                                      "ChannelType: SIP\r\n"
                                                      "Peer: SIP/%s\r\n"
@@ -13868,14 +13871,15 @@ static enum check_auth_result register_verify(struct sip_pvt *p, struct ast_sock
                                                      "Port: %s\r\n",
                                                      name,
                                                      res == AUTH_PEER_NOT_DYNAMIC ? "AUTH_PEER_NOT_DYNAMIC" : "URI_NOT_FOUND",
-                                                     ast_strdupa(ast_sockaddr_stringify_addr(addr)),
-                                                     ast_strdupa(ast_sockaddr_stringify_port(addr)));
+                                                     peer_addr, peer_port);
                                }
                        } else {
                                /* URI not found */
                                if (res == AUTH_PEER_NOT_DYNAMIC) {
                                        transmit_response(p, "403 Forbidden", &p->initreq);
                                        if (global_authfailureevents) {
+                                               const char *peer_addr = ast_strdupa(ast_sockaddr_stringify_addr(addr));
+                                               const char *peer_port = ast_strdupa(ast_sockaddr_stringify_port(addr));
                                                manager_event(EVENT_FLAG_SYSTEM, "PeerStatus",
                                                        "ChannelType: SIP\r\n"
                                                        "Peer: SIP/%s\r\n"
@@ -13883,13 +13887,13 @@ static enum check_auth_result register_verify(struct sip_pvt *p, struct ast_sock
                                                        "Cause: AUTH_PEER_NOT_DYNAMIC\r\n"
                                                        "Address: %s\r\n"
                                                        "Port: %s\r\n",
-                                                       name,
-                                                       ast_strdupa(ast_sockaddr_stringify_addr(addr)),
-                                                       ast_strdupa(ast_sockaddr_stringify_port(addr)));
+                                                       name, peer_addr, peer_port);
                                        }
                                } else {
                                        transmit_response(p, "404 Not found", &p->initreq);
                                        if (global_authfailureevents) {
+                                               const char *peer_addr = ast_strdupa(ast_sockaddr_stringify_addr(addr));
+                                               const char *peer_port = ast_strdupa(ast_sockaddr_stringify_port(addr));
                                                manager_event(EVENT_FLAG_SYSTEM, "PeerStatus",
                                                        "ChannelType: SIP\r\n"
                                                        "Peer: SIP/%s\r\n"
@@ -13899,8 +13903,7 @@ static enum check_auth_result register_verify(struct sip_pvt *p, struct ast_sock
                                                        "Port: %s\r\n",
                                                        name,
                                                        (res == AUTH_USERNAME_MISMATCH) ? "AUTH_USERNAME_MISMATCH" : "URI_NOT_FOUND",
-                                                       ast_strdupa(ast_sockaddr_stringify_addr(addr)),
-                                                       ast_strdupa(ast_sockaddr_stringify_port(addr)));
+                                                       peer_addr, peer_port);
                                        }
                                }
                        }
@@ -16908,9 +16911,9 @@ static char *sip_show_settings(struct ast_cli_entry *e, int cmd, struct ast_cli_
                const char *prefix = "Localnet:";
 
                for (d = localaddr; d ; prefix = "", d = d->next) {
-                       ast_cli(a->fd, "  %-24s%s/%s\n",
-                           prefix, ast_strdupa(ast_sockaddr_stringify_addr(&d->addr)),
-                           ast_strdupa(ast_sockaddr_stringify_addr(&d->netmask)));
+                       const char *addr = ast_strdupa(ast_sockaddr_stringify_addr(&d->addr));
+                       const char *mask = ast_strdupa(ast_sockaddr_stringify_addr(&d->netmask));
+                       ast_cli(a->fd, "  %-24s%s/%s\n", prefix, addr, mask);
                }
        }
        ast_cli(a->fd, "\nGlobal Signalling Settings:\n");
@@ -27274,8 +27277,11 @@ static int apply_directmedia_ha(struct sip_pvt *p, const char *op)
        ast_rtp_instance_get_local_address(p->rtp, &us);
 
        if ((res = ast_apply_ha(p->directmediaha, &them)) == AST_SENSE_DENY) {
+               const char *us_addr = ast_strdupa(ast_sockaddr_stringify(&us));
+               const char *them_addr = ast_strdupa(ast_sockaddr_stringify(&them));
+
                ast_debug(3, "Reinvite %s to %s denied by directmedia ACL on %s\n",
-                       op, ast_strdupa(ast_sockaddr_stringify(&them)), ast_strdupa(ast_sockaddr_stringify(&us)));
+                       op, them_addr, us_addr);
        }
 
        return res;

diff --git a/main/acl.c b/main/acl.c
index 4ab102736c6c71a91b87d3e724f0bf011b10a1c1..79f378123cd348e550d55c9711cc7aeb4dc8af8e 100644 (file)
--- a/main/acl.c
+++ b/main/acl.c
@@ -488,7 +488,12 @@ struct ast_ha *ast_append_ha(const char *sense, const char *stuff, struct ast_ha
                ret = ha;
        }
 
-       ast_debug(1, "%s/%s sense %d appended to acl for peer\n", ast_strdupa(ast_sockaddr_stringify(&ha->addr)), ast_strdupa(ast_sockaddr_stringify(&ha->netmask)), ha->sense);
+       {
+               const char *addr = ast_strdupa(ast_sockaddr_stringify(&ha->addr));
+               const char *mask = ast_strdupa(ast_sockaddr_stringify(&ha->netmask));
+
+               ast_debug(1, "%s/%s sense %d appended to acl for peer\n", addr, mask, ha->sense);
+       }
 
        return ret;
 }
@@ -701,9 +706,14 @@ int ast_ouraddrfor(const struct ast_sockaddr *them, struct ast_sockaddr *us)
                return -1;
        }
        close(s);
-       ast_debug(3, "For destination '%s', our source address is '%s'.\n",
-                 ast_strdupa(ast_sockaddr_stringify_addr(them)),
-                 ast_strdupa(ast_sockaddr_stringify_addr(us)));
+
+       {
+               const char *them_addr = ast_strdupa(ast_sockaddr_stringify_addr(them));
+               const char *us_addr = ast_strdupa(ast_sockaddr_stringify_addr(us));
+
+               ast_debug(3, "For destination '%s', our source address is '%s'.\n",
+                               them_addr, us_addr);
+       }
 
        ast_sockaddr_set_port(us, port);
 

diff --git a/main/dnsmgr.c b/main/dnsmgr.c
index 7036708c752c4a751ac723cbb1f5839cebae2611..7fb5f88031b8a13129d33b653555aa12365d44a4 100644 (file)
--- a/main/dnsmgr.c
+++ b/main/dnsmgr.c
@@ -151,22 +151,26 @@ int ast_dnsmgr_lookup(const char *name, struct ast_sockaddr *result, struct ast_
  */
 static int dnsmgr_refresh(struct ast_dnsmgr_entry *entry, int verbose)
 {
-       struct ast_sockaddr tmp;
+       struct ast_sockaddr tmp = { .len = 0, };
        int changed = 0;
 
        ast_mutex_lock(&entry->lock);
-       if (verbose)
-               ast_verb(3, "refreshing '%s'\n", entry->name);
 
-       memset(&tmp, 0, sizeof(tmp));
+       if (verbose) {
+               ast_verb(3, "refreshing '%s'\n", entry->name);
+       }
 
        if (!ast_get_ip_or_srv(&tmp, entry->name, entry->service)) {
-               if (!ast_sockaddr_port(&tmp))
+               if (!ast_sockaddr_port(&tmp)) {
                        ast_sockaddr_set_port(&tmp, ast_sockaddr_port(entry->result));
+               }
+
                if (ast_sockaddr_cmp(&tmp, entry->result)) {
+                       const char *old_addr = ast_strdupa(ast_sockaddr_stringify(entry->result));
+                       const char *new_addr = ast_strdupa(ast_sockaddr_stringify(&tmp));
+
                        ast_log(LOG_NOTICE, "dnssrv: host '%s' changed from %s to %s\n",
-                                       entry->name, ast_strdupa(ast_sockaddr_stringify(entry->result)),
-                                       ast_strdupa(ast_sockaddr_stringify(&tmp)));
+                                       entry->name, old_addr, new_addr);
 
                        ast_sockaddr_copy(entry->result, &tmp);
                        changed = entry->changed = 1;
@@ -174,6 +178,7 @@ static int dnsmgr_refresh(struct ast_dnsmgr_entry *entry, int verbose)
        }
 
        ast_mutex_unlock(&entry->lock);
+
        return changed;
 }
 

diff --git a/res/res_rtp_asterisk.c b/res/res_rtp_asterisk.c
index 6ddd33902c1dd34cd07eb7ec8f24175c43dc152c..643794890be71c61a96ea8394b7f10b7aed0ef46 100644 (file)
--- a/res/res_rtp_asterisk.c
+++ b/res/res_rtp_asterisk.c
@@ -2012,9 +2012,12 @@ static struct ast_frame *ast_rtp_read(struct ast_rtp_instance *instance, int rtc
                                ast_sockaddr_copy(&rtp->strict_rtp_address,
                                                  &addr);
                        } else  {
+                               const char *real_addr = ast_strdupa(ast_sockaddr_stringify(&addr));
+                               const char *expected_addr = ast_strdupa(ast_sockaddr_stringify(&rtp->strict_rtp_address));
+
                                ast_debug(1, "Received RTP packet from %s, dropping due to strict RTP protection. Expected it to be from %s\n",
-                                         ast_strdupa(ast_sockaddr_stringify(&addr)),
-                                         ast_strdupa(ast_sockaddr_stringify(&rtp->strict_rtp_address)));
+                                               real_addr, expected_addr);
+
                                return &ast_null_frame;
                        }
                }