ACPI: property: Fix buffer properties extraction for subnodes

The ACPI handle passed to acpi_extract_properties() as the first
argument represents the ACPI namespace scope in which to look for
objects returning buffers associated with buffer properties.

For _DSD objects located immediately under ACPI devices, this handle is
the same as the handle of the device object holding the _DSD, but for
data-only subnodes it is not so.

First of all, data-only subnodes are represented by objects that
cannot hold other objects in their scopes (like control methods).
Therefore a data-only subnode handle cannot be used for completing
relative pathname segments, so the current code in
in acpi_nondev_subnode_extract() passing a data-only subnode handle
to acpi_extract_properties() is invalid.

Moreover, a data-only subnode of device A may be represented by an
object located in the scope of device B (which kind of makes sense,
for instance, if A is a B's child).  In that case, the scope in
question would be the one of device B.  In other words, the scope
mentioned above is the same as the scope used for subnode object
lookup in acpi_nondev_subnode_extract().

Accordingly, rearrange that function to use the same scope for the
extraction of properties and subnode object lookup.

Fixes: 103e10c69c61 ("ACPI: property: Add support for parsing buffer property UUID")
Cc: 6.0+ <stable@vger.kernel.org> # 6.0+
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Tested-by: Sakari Ailus <sakari.ailus@linux.intel.com>

diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c
index 436019d96027bd3bfdcdc49fb82dfb8629df1659..83b03dce576c504760cfd82b452182672794a633 100644 (file)
--- a/drivers/acpi/property.c
+++ b/drivers/acpi/property.c
@@ -83,6 +83,7 @@ static bool acpi_nondev_subnode_extract(union acpi_object *desc,
                                        struct fwnode_handle *parent)
 {
        struct acpi_data_node *dn;
+       acpi_handle scope = NULL;
        bool result;
 
        if (acpi_graph_ignore_port(handle))
@@ -98,27 +99,18 @@ static bool acpi_nondev_subnode_extract(union acpi_object *desc,
        INIT_LIST_HEAD(&dn->data.properties);
        INIT_LIST_HEAD(&dn->data.subnodes);
 
-       result = acpi_extract_properties(handle, desc, &dn->data);
-
-       if (handle) {
-               acpi_handle scope;
-               acpi_status status;
+       /*
+        * The scope for the completion of relative pathname segments and
+        * subnode object lookup is the one of the namespace node (device)
+        * containing the object that has returned the package.  That is, it's
+        * the scope of that object's parent device.
+        */
+       if (handle)
+               acpi_get_parent(handle, &scope);
 
-               /*
-                * The scope for the subnode object lookup is the one of the
-                * namespace node (device) containing the object that has
-                * returned the package.  That is, it's the scope of that
-                * object's parent.
-                */
-               status = acpi_get_parent(handle, &scope);
-               if (ACPI_SUCCESS(status)
-                   && acpi_enumerate_nondev_subnodes(scope, desc, &dn->data,
-                                                     &dn->fwnode))
-                       result = true;
-       } else if (acpi_enumerate_nondev_subnodes(NULL, desc, &dn->data,
-                                                 &dn->fwnode)) {
+       result = acpi_extract_properties(scope, desc, &dn->data);
+       if (acpi_enumerate_nondev_subnodes(scope, desc, &dn->data, &dn->fwnode))
                result = true;
-       }
 
        if (result) {
                dn->handle = handle;