RDMA/hns: Fix undifined behavior caused by invalid max_sge

[ Upstream commit 36397b907355e2fdb5a25a02a7921a937fd8ef4c ]

If max_sge has been set to 0, roundup_pow_of_two() in
set_srq_basic_param() may have undefined behavior.

Fixes: 9dd052474a26 ("RDMA/hns: Allocate one more recv SGE for HIP08")
Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
Signed-off-by: Junxian Huang <huangjunxian6@hisilicon.com>
Link: https://lore.kernel.org/r/20240710133705.896445-7-huangjunxian6@hisilicon.com
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/infiniband/hw/hns/hns_roce_srq.c b/drivers/infiniband/hw/hns/hns_roce_srq.c
index f1997abc97cac84503f0a3611a1c5bdc9cbffb7e..c9b8233f4b0577edcba5d8d87a63e7d28c460ab1 100644 (file)
--- a/drivers/infiniband/hw/hns/hns_roce_srq.c
+++ b/drivers/infiniband/hw/hns/hns_roce_srq.c
@@ -297,7 +297,7 @@ static int set_srq_basic_param(struct hns_roce_srq *srq,
 
        max_sge = proc_srq_sge(hr_dev, srq, !!udata);
        if (attr->max_wr > hr_dev->caps.max_srq_wrs ||
-           attr->max_sge > max_sge) {
+           attr->max_sge > max_sge || !attr->max_sge) {
                ibdev_err(&hr_dev->ib_dev,
                          "invalid SRQ attr, depth = %u, sge = %u.\n",
                          attr->max_wr, attr->max_sge);