]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
blocklayoutdriver: Fix reference leak of pnfs_device_node
authorBenjamin Coddington <bcodding@redhat.com>
Tue, 5 Dec 2023 15:05:01 +0000 (10:05 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Jan 2024 22:52:36 +0000 (14:52 -0800)
[ Upstream commit 1530827b90025cdf80c9b0d07a166d045a0a7b81 ]

The error path for blocklayout's device lookup is missing a reference drop
for the case where a lookup finds the device, but the device is marked with
NFS_DEVICEID_UNAVAILABLE.

Fixes: b3dce6a2f060 ("pnfs/blocklayout: handle transient devices")
Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/nfs/blocklayout/blocklayout.c

index fe860c53874768552912293fcd22e5c278bcb829..dc657b12822dd5b744ba9e91c6b8e2473dc1376f 100644 (file)
@@ -599,6 +599,8 @@ retry:
                nfs4_delete_deviceid(node->ld, node->nfs_client, id);
                goto retry;
        }
+
+       nfs4_put_deviceid_node(node);
        return ERR_PTR(-ENODEV);
 }