Use proper mode_t types and macros.

Don't assume the traditional Unix values for mode bits.

diff --git a/src/mkfifo.c b/src/mkfifo.c
index a08ab57d25c56de22eb36cd55e339654ab547438..fea25f330e976e9e98606c73f5dcb24e6b008335 100644 (file)
--- a/src/mkfifo.c
+++ b/src/mkfifo.c
@@ -60,7 +60,7 @@ usage (int status)
       printf (_("\
 Create named pipes (FIFOs) with the given NAMEs.\n\
 \n\
-  -m, --mode=MODE   set permission mode (as in chmod), not 0666 - umask\n\
+  -m, --mode=MODE   set permission mode (as in chmod), not a=rw - umask\n\
       --help        display this help and exit\n\
       --version     output version information and exit\n\
 "));
@@ -74,7 +74,7 @@ Create named pipes (FIFOs) with the given NAMEs.\n\
 int
 main (int argc, char **argv)
 {
-  unsigned short newmode;
+  mode_t newmode;
   struct mode_change *change;
   const char *symbolic_mode;
   int errors = 0;
@@ -112,7 +112,8 @@ main (int argc, char **argv)
       usage (1);
     }
 
-  newmode = 0666 & ~umask (0);
+  newmode = ((S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH | S_IWOTH)
+            & ~ umask (0));
   if (symbolic_mode)
     {
       change = mode_compile (symbolic_mode, 0);