]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
spi: tegra210-quad: Remove redundant pm_runtime_mark_last_busy() calls
authorFelix Gu <ustc.gu@gmail.com>
Sat, 7 Mar 2026 07:24:45 +0000 (15:24 +0800)
committerMark Brown <broonie@kernel.org>
Tue, 10 Mar 2026 19:47:30 +0000 (19:47 +0000)
pm_runtime_put_autosuspend() already internally updates the last_busy
timestamp before scheduling the autosuspend, making explicit
pm_runtime_mark_last_busy() calls immediately before it redundant.

Fixes: 7c12f6ead467 ("spi: tegra210-quad: Add runtime autosuspend support")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Link: https://patch.msgid.link/20260307-quad-v1-1-f103515db501@gmail.com
drivers/spi/spi-tegra210-quad.c

index 7fac695b514219e422c6fcb924376a10943a371f..7cca5578eba314dddc5ca52b16960ccf43d55a57 100644 (file)
@@ -1000,7 +1000,6 @@ static int tegra_qspi_setup(struct spi_device *spi)
 
        spin_unlock_irqrestore(&tqspi->lock, flags);
 
-       pm_runtime_mark_last_busy(tqspi->dev);
        pm_runtime_put_autosuspend(tqspi->dev);
 
        return 0;
@@ -1790,7 +1789,6 @@ static int tegra_qspi_probe(struct platform_device *pdev)
        tqspi->spi_cs_timing2 = tegra_qspi_readl(tqspi, QSPI_CS_TIMING2);
        tqspi->def_command2_reg = tegra_qspi_readl(tqspi, QSPI_COMMAND2);
 
-       pm_runtime_mark_last_busy(&pdev->dev);
        pm_runtime_put_autosuspend(&pdev->dev);
 
        ret = request_threaded_irq(tqspi->irq, NULL,
@@ -1851,7 +1849,6 @@ static int __maybe_unused tegra_qspi_resume(struct device *dev)
 
        tegra_qspi_writel(tqspi, tqspi->command1_reg, QSPI_COMMAND1);
        tegra_qspi_writel(tqspi, tqspi->def_command2_reg, QSPI_COMMAND2);
-       pm_runtime_mark_last_busy(dev);
        pm_runtime_put_autosuspend(dev);
 
        return spi_controller_resume(host);