mdbox: Add assert to help static analyzers

mdbox_sync_begin() can return 0 with sync_ctx=NULL, but not with the
parameters given here.

diff --git a/src/lib-storage/index/dbox-multi/mdbox-save.c b/src/lib-storage/index/dbox-multi/mdbox-save.c
index ff6e4f77b08a2f7c74e89c00f9485ffce02b82e7..8a614e7c51faf6d8028c33ece64e2f010b317f17 100644 (file)
--- a/src/lib-storage/index/dbox-multi/mdbox-save.c
+++ b/src/lib-storage/index/dbox-multi/mdbox-save.c
@@ -310,6 +310,7 @@ int mdbox_transaction_save_commit_pre(struct mail_save_context *_ctx)
                mdbox_transaction_save_rollback(_ctx);
                return -1;
        }
+       i_assert(ctx->sync_ctx != NULL);
 
        /* assign map UIDs for newly saved messages after we've successfully
           acquired all the locks. the transaction is now very unlikely to