]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-102251: Fix reference leak in _testsinglephase initialization (#105082)
authorsunmy2019 <59365878+sunmy2019@users.noreply.github.com>
Tue, 30 May 2023 09:27:55 +0000 (17:27 +0800)
committerGitHub <noreply@github.com>
Tue, 30 May 2023 09:27:55 +0000 (09:27 +0000)
Correctly decref 'initialized' in init_module()

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Modules/_testsinglephase.c

index a16157702ae7891bd733c3b3b7c521e7ed4f2355..8e6973f0b052cc2ae0acdccca40500d9d98238c6 100644 (file)
@@ -140,7 +140,9 @@ init_module(PyObject *module, module_state *state)
     if (initialized == NULL) {
         return -1;
     }
-    if (PyModule_AddObjectRef(module, "_module_initialized", initialized) != 0) {
+    int rc = PyModule_AddObjectRef(module, "_module_initialized", initialized);
+    Py_DECREF(initialized);
+    if (rc < 0) {
         return -1;
     }