gh-141510: Change repr(frozendict) for empty dict (#144921)

repr(frozendict()) returns "frozendict()" instead of
"frozendict({})".

diff --git a/Lib/test/test_dict.py b/Lib/test/test_dict.py
index 2a106a8a4e873952375fb9853b99ae76f67899e9..21f8bb11071c90cb3f10d8536b346e9e7b5f7f11 100644 (file)
--- a/Lib/test/test_dict.py
+++ b/Lib/test/test_dict.py
@@ -1767,6 +1767,9 @@ class FrozenDictTests(unittest.TestCase):
         self.assertEqual(copy, frozendict({'x': 1}))
 
     def test_repr(self):
+        d = frozendict()
+        self.assertEqual(repr(d), "frozendict()")
+
         d = frozendict(x=1, y=2)
         self.assertEqual(repr(d), "frozendict({'x': 1, 'y': 2})")
 

diff --git a/Objects/dictobject.c b/Objects/dictobject.c
index f7a359e4a1a40d157e59dcd383aa587082248b3a..7db2e547b54dba20779bd3ece0ae66358f3c6faf 100644 (file)
--- a/Objects/dictobject.c
+++ b/Objects/dictobject.c
@@ -7868,6 +7868,11 @@ static PyMethodDef frozendict_methods[] = {
 static PyObject *
 frozendict_repr(PyObject *self)
 {
+    PyDictObject *mp = _PyAnyDict_CAST(self);
+    if (mp->ma_used == 0) {
+        return PyUnicode_FromFormat("%s()", Py_TYPE(self)->tp_name);
+    }
+
     PyObject *repr = anydict_repr_impl(self);
     if (repr == NULL) {
         return NULL;