]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
platform/x86: dell-wmi-sysman: Don't hex dump plaintext password data
authorThorsten Blum <thorsten.blum@linux.dev>
Tue, 3 Mar 2026 11:30:51 +0000 (12:30 +0100)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Tue, 3 Mar 2026 12:45:17 +0000 (14:45 +0200)
set_new_password() hex dumps the entire buffer, which contains plaintext
password data, including current and new passwords. Remove the hex dump
to avoid leaking credentials.

Fixes: e8a60aa7404b ("platform/x86: Introduce support for Systems Management Driver over WMI for Dell Systems")
Cc: stable@vger.kernel.org
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Link: https://patch.msgid.link/20260303113050.58127-2-thorsten.blum@linux.dev
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/dell/dell-wmi-sysman/passwordattr-interface.c

index 86ec962aace9b8d803ed588c339e6486607fe59e..e586f7957946bfb674f93402cc6936a43bc2955e 100644 (file)
@@ -93,7 +93,6 @@ int set_new_password(const char *password_type, const char *new)
        if (ret < 0)
                goto out;
 
-       print_hex_dump_bytes("set new password data: ", DUMP_PREFIX_NONE, buffer, buffer_size);
        ret = call_password_interface(wmi_priv.password_attr_wdev, buffer, buffer_size);
        /* on success copy the new password to current password */
        if (!ret)