]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-119896: Fix CTRL-Z behavior in the new REPL on Windows (GH-122217)
authorDino Viehland <dinoviehland@meta.com>
Tue, 30 Jul 2024 12:03:52 +0000 (05:03 -0700)
committerGitHub <noreply@github.com>
Tue, 30 Jul 2024 12:03:52 +0000 (14:03 +0200)
Lib/_pyrepl/reader.py
Lib/_pyrepl/simple_interact.py
Lib/_pyrepl/utils.py
Lib/_pyrepl/windows_console.py

index 8b282a382d374f10cf2a4a13ab21e4fa50d6d59c..13b1f3eb9d118aabbf6296bcb13de0553e4b9abe 100644 (file)
@@ -21,6 +21,8 @@
 
 from __future__ import annotations
 
+import sys
+
 from contextlib import contextmanager
 from dataclasses import dataclass, field, fields
 import unicodedata
@@ -52,7 +54,10 @@ def disp_str(buffer: str) -> tuple[str, list[int]]:
     b: list[int] = []
     s: list[str] = []
     for c in buffer:
-        if ord(c) < 128:
+        if c == '\x1a':
+            s.append(c)
+            b.append(2)
+        elif ord(c) < 128:
             s.append(c)
             b.append(1)
         elif unicodedata.category(c).startswith("C"):
@@ -110,7 +115,7 @@ default_keymap: tuple[tuple[KeySpec, CommandName], ...] = tuple(
         (r"\C-w", "unix-word-rubout"),
         (r"\C-x\C-u", "upcase-region"),
         (r"\C-y", "yank"),
-        (r"\C-z", "suspend"),
+        *(() if sys.platform == "win32" else ((r"\C-z", "suspend"), )),
         (r"\M-b", "backward-word"),
         (r"\M-c", "capitalize-word"),
         (r"\M-d", "kill-word"),
index 2c3dffe070c629621ee090278c820202a387bb59..91aef5e01eb86712595f5e408256d8d0cd2ddaa9 100644 (file)
@@ -76,6 +76,7 @@ REPL_COMMANDS = {
     "copyright": _sitebuiltins._Printer('copyright', sys.copyright),
     "help": "help",
     "clear": _clear_screen,
+    "\x1a": _sitebuiltins.Quitter('\x1a', ''),
 }
 
 
index 20dbb1f7e172295df559a986d1737da0107e5885..0f36083b6ffa92cd95c75957f3d0734da852052d 100644 (file)
@@ -21,4 +21,5 @@ def wlen(s: str) -> int:
     length = sum(str_width(i) for i in s)
     # remove lengths of any escape sequences
     sequence = ANSI_ESCAPE_SEQUENCE.findall(s)
-    return length - sum(len(i) for i in sequence)
+    ctrl_z_cnt = s.count('\x1a')
+    return length - sum(len(i) for i in sequence) + ctrl_z_cnt
index 9e97b1524e29a0abe20de1890b4c414d739976c5..ba9af36b8be99c364a9702ea5d61346aca4f192a 100644 (file)
@@ -253,7 +253,7 @@ class WindowsConsole(Console):
         else:
             self.__posxy = wlen(newline), y
 
-            if "\x1b" in newline or y != self.__posxy[1]:
+            if "\x1b" in newline or y != self.__posxy[1] or '\x1a' in newline:
                 # ANSI escape characters are present, so we can't assume
                 # anything about the position of the cursor.  Moving the cursor
                 # to the left margin should work to get to a known position.
@@ -291,6 +291,9 @@ class WindowsConsole(Console):
         self.__write("\x1b[?12l")
 
     def __write(self, text: str) -> None:
+        if "\x1a" in text:
+            text = ''.join(["^Z" if x == '\x1a' else x for x in text])
+
         if self.out is not None:
             self.out.write(text.encode(self.encoding, "replace"))
             self.out.flush()