]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-114492: Initialize struct termios before calling tcgetattr() (GH-114495)
authorSerhiy Storchaka <storchaka@gmail.com>
Tue, 23 Jan 2024 21:27:04 +0000 (23:27 +0200)
committerGitHub <noreply@github.com>
Tue, 23 Jan 2024 21:27:04 +0000 (23:27 +0200)
On Alpine Linux it could leave some field non-initialized.

Misc/NEWS.d/next/Library/2024-01-23-21-20-40.gh-issue-114492.vKxl5o.rst [new file with mode: 0644]
Modules/termios.c

diff --git a/Misc/NEWS.d/next/Library/2024-01-23-21-20-40.gh-issue-114492.vKxl5o.rst b/Misc/NEWS.d/next/Library/2024-01-23-21-20-40.gh-issue-114492.vKxl5o.rst
new file mode 100644 (file)
index 0000000..8df8299
--- /dev/null
@@ -0,0 +1,2 @@
+Make the result of :func:`termios.tcgetattr` reproducible on Alpine Linux.
+Previously it could leave a random garbage in some fields.
index c4f0fd9d50044aa2085897de97793f6003a15ea0..69dbd88be5fcc20054a9c892623c58542d9fc744 100644 (file)
@@ -98,6 +98,8 @@ termios_tcgetattr_impl(PyObject *module, int fd)
     struct termios mode;
     int r;
 
+    /* Alpine Linux can leave some fields uninitialized. */
+    memset(&mode, 0, sizeof(mode));
     Py_BEGIN_ALLOW_THREADS
     r = tcgetattr(fd, &mode);
     Py_END_ALLOW_THREADS