]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
PCI: rzg3s-host: Fix reset handling in probe error path
authorJohn Madieu <john.madieu.xa@bp.renesas.com>
Fri, 6 Mar 2026 14:34:08 +0000 (15:34 +0100)
committerManivannan Sadhasivam <mani@kernel.org>
Sun, 15 Mar 2026 15:28:14 +0000 (20:58 +0530)
Fix incorrect reset_control_bulk_deassert() call in the probe error
path. When unwinding from a failed pci_host_probe(), the configuration
resets should be asserted to restore the hardware to its initial state,
not deasserted again.

Fixes: 7ef502fb35b2 ("PCI: Add Renesas RZ/G3S host controller driver")
Signed-off-by: John Madieu <john.madieu.xa@bp.renesas.com>
Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> # RZ/V2N EVK
Tested-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Link: https://patch.msgid.link/20260306143423.19562-2-john.madieu.xa@bp.renesas.com
drivers/pci/controller/pcie-rzg3s-host.c

index 2809112e6317143bfd573e703ef358bf71e853c9..7a80455aad366f1faaf7c97f64043ef214fb4620 100644 (file)
@@ -1589,8 +1589,7 @@ static int rzg3s_pcie_probe(struct platform_device *pdev)
 
 host_probe_teardown:
        rzg3s_pcie_teardown_irqdomain(host);
-       reset_control_bulk_deassert(host->data->num_cfg_resets,
-                                   host->cfg_resets);
+       reset_control_bulk_assert(host->data->num_cfg_resets, host->cfg_resets);
 rpm_put:
        pm_runtime_put_sync(dev);
 rpm_disable: