]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
bpo-42773: fix tests not being run on pushes (GH-24004)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Wed, 3 Feb 2021 23:34:21 +0000 (15:34 -0800)
committerGitHub <noreply@github.com>
Wed, 3 Feb 2021 23:34:21 +0000 (15:34 -0800)
There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns <lains@riseup.net>
(cherry picked from commit 4ac923f2756f835f512339ee181348cc535ab07f)

Co-authored-by: Filipe Laíns <lains@riseup.net>
.github/workflows/build.yml

index e7426ac8c5469694e7c955a2f9ad0703e5794465..669c541dd4f49b8b6b34c678c350f92ff68c455c 100644 (file)
@@ -21,7 +21,7 @@ jobs:
       - name: Check for source changes
         id: check
         run: |
-          if [ -z "GITHUB_BASE_REF" ]; then
+          if [ -z "$GITHUB_BASE_REF" ]; then
             echo '::set-output name=run_tests::true'
           else
             git fetch origin $GITHUB_BASE_REF --depth=1