]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm: lcdif: Use dev_err_probe()
authorAlexander Stein <alexander.stein@ew.tq-group.com>
Wed, 4 Mar 2026 14:04:25 +0000 (15:04 +0100)
committerLiu Ying <victor.liu@nxp.com>
Tue, 10 Mar 2026 01:42:09 +0000 (09:42 +0800)
Use dev_err_probe() to add a reason for deferred probe. This can
especially happen on lcdif3 which uses hdmi_tx_phy for 'pix' clock

Reviewed-by: Liu Ying <victor.liu@nxp.com>
Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Signed-off-by: Liu Ying <victor.liu@nxp.com>
Link: https://lore.kernel.org/r/20260304140426.1499446-1-alexander.stein@ew.tq-group.com
drivers/gpu/drm/mxsfb/lcdif_drv.c

index fcb2a7517377e9a5bbd2997c578c579b1b079f92..47da1d9336b90a3d21c64fd7df3481da1fbb87de 100644 (file)
@@ -149,15 +149,17 @@ static int lcdif_load(struct drm_device *drm)
 
        lcdif->clk = devm_clk_get(drm->dev, "pix");
        if (IS_ERR(lcdif->clk))
-               return PTR_ERR(lcdif->clk);
+               return dev_err_probe(drm->dev, PTR_ERR(lcdif->clk), "Failed to get pix clock\n");
 
        lcdif->clk_axi = devm_clk_get(drm->dev, "axi");
        if (IS_ERR(lcdif->clk_axi))
-               return PTR_ERR(lcdif->clk_axi);
+               return dev_err_probe(drm->dev, PTR_ERR(lcdif->clk_axi),
+                                    "Failed to get axi clock\n");
 
        lcdif->clk_disp_axi = devm_clk_get(drm->dev, "disp_axi");
        if (IS_ERR(lcdif->clk_disp_axi))
-               return PTR_ERR(lcdif->clk_disp_axi);
+               return dev_err_probe(drm->dev, PTR_ERR(lcdif->clk_disp_axi),
+                                    "Failed to get disp_axi clock\n");
 
        platform_set_drvdata(pdev, drm);