]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: llc: make empty have static storage duration
authorWentao Guan <guanwentao@uniontech.com>
Tue, 16 Jun 2026 06:40:53 +0000 (14:40 +0800)
committerJakub Kicinski <kuba@kernel.org>
Fri, 19 Jun 2026 00:52:56 +0000 (17:52 -0700)
Make @empty have static storage duration (like net/sysctl_net.c does)
to avoid storing a bad pointer, and keep consistent with
__register_sysctl_table @table 'should not be free'd after registration'.

Note that this is _not_ a bug, since size is 0 the pointer will
never get deferenced.

Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20260616064053.690154-1-guanwentao@uniontech.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/llc/sysctl_net_llc.c

index c8d88e2508fce00054d3718af022e46f8df8d606..15f1e5d88f208d8a4759055ff4d782c9cdc95b4b 100644 (file)
@@ -47,7 +47,7 @@ static struct ctl_table_header *llc_station_header;
 
 int __init llc_sysctl_init(void)
 {
-       struct ctl_table empty[1] = {};
+       static struct ctl_table empty[1] = {};
        llc2_timeout_header = register_net_sysctl(&init_net, "net/llc/llc2/timeout", llc2_timeout_table);
        llc_station_header = register_net_sysctl_sz(&init_net, "net/llc/station", empty, 0);