]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3/librpc/crypto: clang: warning: Value stored to 'gss_maj' is never read
authorNoel Power <noel.power@suse.com>
Fri, 2 Aug 2019 10:45:48 +0000 (10:45 +0000)
committerNoel Power <npower@samba.org>
Wed, 25 Sep 2019 09:47:31 +0000 (09:47 +0000)
Fixes: Value stored to 'gss_maj' is never read
source3/librpc/crypto/gse.c:562:3: warning: Value stored to 'gss_maj' is never read <--[clang]
                gss_maj = gss_release_buffer(&gss_min, &out_data);
                ^         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
source3/librpc/crypto/gse.c:687:3: warning: Value stored to 'gss_maj' is never read <--[clang]
                gss_maj = gss_release_buffer(&gss_min, &out_data);
                ^         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
source3/librpc/crypto/gse.c:739:3: warning: Value stored to 'gss_maj' is never read <--[clang]
                gss_maj = gss_release_buffer(&gss_min, &msg_min);
                ^         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
source3/librpc/crypto/gse.c:742:3: warning: Value stored to 'gss_maj' is never read <--[clang]
                gss_maj = gss_release_buffer(&gss_min, &msg_maj);
                ^         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
4 warnings generated.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
source3/librpc/crypto/gse.c

index 9a9f4261222f8d954e490d35b7b5a284513efe10..6329b194a278bfffa61adaef22edd877a6bdca80 100644 (file)
@@ -559,7 +559,7 @@ init_sec_context_done:
                        status = NT_STATUS_NO_MEMORY;
                }
 
-               gss_maj = gss_release_buffer(&gss_min, &out_data);
+               gss_release_buffer(&gss_min, &out_data);
        }
 
 done:
@@ -684,7 +684,7 @@ static NTSTATUS gse_get_server_auth_token(TALLOC_CTX *mem_ctx,
                if (!blob.data) {
                        status = NT_STATUS_NO_MEMORY;
                }
-               gss_maj = gss_release_buffer(&gss_min, &out_data);
+               gss_release_buffer(&gss_min, &out_data);
        }
 
 
@@ -736,10 +736,10 @@ static char *gse_errstr(TALLOC_CTX *mem_ctx, OM_uint32 maj, OM_uint32 min)
 
 done:
        if (msg_min.value) {
-               gss_maj = gss_release_buffer(&gss_min, &msg_min);
+               gss_release_buffer(&gss_min, &msg_min);
        }
        if (msg_maj.value) {
-               gss_maj = gss_release_buffer(&gss_min, &msg_maj);
+               gss_release_buffer(&gss_min, &msg_maj);
        }
        return errstr;
 }