]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
irqchip/renesas-rzg2l: Clear the shared interrupt bit in rzg2l_irqc_free()
authorBiju Das <biju.das.jz@bp.renesas.com>
Sat, 28 Mar 2026 10:33:18 +0000 (10:33 +0000)
committerThomas Gleixner <tglx@kernel.org>
Tue, 31 Mar 2026 16:25:29 +0000 (18:25 +0200)
rzg2l_irqc_free() invokes irq_domain_free_irqs_common(), which internally
calls irq_domain_reset_irq_data(). That explicitly sets irq_data->hwirq to
0. Consequently, irqd_to_hwirq(d) returns 0 when called after it.

Since 0 falls outside the valid shared IRQ ranges,
rzg2l_irqc_is_shared_and_get_irq_num() evaluates to false, completely
bypassing the test_and_clear_bit() operation.

This leaves the bit set in priv->used_irqs, causing future allocations to
fail with -EBUSY.

Fix this by retrieving irq_data and caching hwirq before calling
irq_domain_free_irqs_common().

Fixes: e0fcae27ff57 ("irqchip/renesas-rzg2l: Add shared interrupt support")
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Link: https://patch.msgid.link/20260328103324.134131-2-biju.das.jz@bp.renesas.com
drivers/irqchip/irq-renesas-rzg2l.c

index 755fac39de0ca523fbab82ff0ee265431a32b6a9..199b3c6b02c87c04db5a7b5798cf2198cc40d53f 100644 (file)
@@ -698,15 +698,14 @@ shared_irq_free:
 
 static void rzg2l_irqc_free(struct irq_domain *domain, unsigned int virq, unsigned int nr_irqs)
 {
+       struct irq_data *d = irq_domain_get_irq_data(domain, virq);
        struct rzg2l_irqc_priv *priv = domain->host_data;
+       irq_hw_number_t hwirq = irqd_to_hwirq(d);
 
        irq_domain_free_irqs_common(domain, virq, nr_irqs);
 
-       if (priv->info.shared_irq_cnt) {
-               struct irq_data *d = irq_domain_get_irq_data(domain, virq);
-
-               rzg2l_irqc_shared_irq_free(priv, irqd_to_hwirq(d));
-       }
+       if (priv->info.shared_irq_cnt)
+               rzg2l_irqc_shared_irq_free(priv, hwirq);
 }
 
 static const struct irq_domain_ops rzg2l_irqc_domain_ops = {