]> git.ipfire.org Git - thirdparty/curl.git/commitdiff
rustls: exit on error
authorDaniel Stenberg <daniel@haxx.se>
Sat, 18 Oct 2025 21:34:52 +0000 (23:34 +0200)
committerDaniel Stenberg <daniel@haxx.se>
Sun, 19 Oct 2025 21:47:47 +0000 (23:47 +0200)
In init_config_builder_verifier() the call to
rustls_root_cert_store_builder_build() set result on failure but did not
return.

Pointed out by ZeroPath
Closes #19125

lib/vtls/rustls.c

index ebd94213d4934c72fbb1718a66c2f9329f07bcee..2173b3be88ba5c453692e7f08c2e87ba2a2e6f4f 100644 (file)
@@ -746,6 +746,9 @@ init_config_builder_verifier(struct Curl_easy *data,
   if(rr != RUSTLS_RESULT_OK) {
     rustls_failf(data, rr, "failed to build trusted root certificate store");
     result = CURLE_SSL_CACERT_BADFILE;
+    if(result) {
+      goto cleanup;
+    }
   }
 
   verifier_builder = rustls_web_pki_server_cert_verifier_builder_new(roots);
@@ -754,7 +757,7 @@ init_config_builder_verifier(struct Curl_easy *data,
     result = init_config_builder_verifier_crl(data,
                                              conn_config,
                                              verifier_builder);
-    if(result != CURLE_OK) {
+    if(result) {
       goto cleanup;
     }
   }