s4/ldap_backend: fix a NULL dereference

Signed-off-by: Bjoern Jacke <bjacke@samba.org>>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

diff --git a/source4/ldap_server/ldap_backend.c b/source4/ldap_server/ldap_backend.c
index 4e94417c21b46482543be490d1fdb95c45301f93..3bcd984f1498857f03f8eb3e9da58333fb07f3f3 100644 (file)
--- a/source4/ldap_server/ldap_backend.c
+++ b/source4/ldap_server/ldap_backend.c
@@ -288,14 +288,15 @@ static NTSTATUS ldapsrv_encode(TALLOC_CTX *mem_ctx,
                                samba_ldap_control_handlers(),
                                &reply->blob,
                                mem_ctx);
-       TALLOC_FREE(reply->msg);
        if (!bret) {
                DEBUG(0,("Failed to encode ldap reply of type %d: "
                         "ldap_encode() failed\n",
                         reply->msg->type));
+               TALLOC_FREE(reply->msg);
                return NT_STATUS_NO_MEMORY;
        }
 
+       TALLOC_FREE(reply->msg);
        talloc_set_name_const(reply->blob.data,
                              "Outgoing, encoded single LDAP reply");