parser: Fix for memleak when commands fail

In case of failing command evaluation, commands need to be freed as
their memory becomes orphaned afterwards.

Signed-off-by: Phil Sutter <phil@nwl.cc>

diff --git a/src/parser_bison.y b/src/parser_bison.y
index a8b71cddc192030737075ece45faa08dc9d86deb..d149178c2679bbd4d88bb3fc8a145bd504aac83f 100644 (file)
--- a/src/parser_bison.y
+++ b/src/parser_bison.y
@@ -692,6 +692,7 @@ input                       :       /* empty */
 
                                        list_add_tail(&$2->list, &list);
                                        if (cmd_evaluate(&state->ectx, $2) < 0) {
+                                               cmd_free($2);
                                                if (++state->nerrs == nft->parser_max_errors)
                                                        YYABORT;
                                        } else
@@ -758,6 +759,7 @@ line                        :       common_block                    { $$ = NULL; }
 
                                        list_add_tail(&$1->list, &list);
                                        if (cmd_evaluate(&state->ectx, $1) < 0) {
+                                               cmd_free($1);
                                                if (++state->nerrs == nft->parser_max_errors)
                                                        YYABORT;
                                        } else