]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ALSA: firewire: dice: Fix printf warning with W=1
authorTakashi Iwai <tiwai@suse.de>
Fri, 27 Feb 2026 15:57:00 +0000 (16:57 +0100)
committerTakashi Iwai <tiwai@suse.de>
Sat, 28 Feb 2026 08:31:13 +0000 (09:31 +0100)
The use of snprintf() may cause a warning with W=1 due to the possibly
truncated string.  As the truncation doesn't really matter (and won't
happen practically) in the case of dice driver, just shut it up by
replacing with scnprintf().

Link: https://patch.msgid.link/20260227155705.1557224-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/firewire/dice/dice.c

index 85d265c7d5444d693f62044eb730dec78962eeed..f7a50bae4b559dd0a4cd9ec3c7d7501a1722396f 100644 (file)
@@ -122,7 +122,7 @@ static void dice_card_strings(struct snd_dice *dice)
        fw_csr_string(dev->config_rom + 5, CSR_VENDOR, vendor, sizeof(vendor));
        strscpy(model, "?");
        fw_csr_string(dice->unit->directory, CSR_MODEL, model, sizeof(model));
-       snprintf(card->longname, sizeof(card->longname),
+       scnprintf(card->longname, sizeof(card->longname),
                 "%s %s (serial %u) at %s, S%d",
                 vendor, model, dev->config_rom[4] & 0x3fffff,
                 dev_name(&dice->unit->device), 100 << dev->max_speed);