]> git.ipfire.org Git - thirdparty/patchwork.git/commitdiff
forms: Remove unused args in forms
authorStephen Finucane <stephen@that.guru>
Sat, 19 Nov 2016 14:02:29 +0000 (14:02 +0000)
committerStephen Finucane <stephen@that.guru>
Sun, 18 Dec 2016 22:42:17 +0000 (22:42 +0000)
There were a couple of forms that offered configurabilty, but this
configurability wasn't used anywhere. Simplify things and remove any
related code.

Signed-off-by: Stephen Finucane <stephen@that.guru>
patchwork/forms.py

index 54bb02a5b1476a63286a29666509525db5d43ecd..b8865b64f4bddab022a0946f1f2b216d0a3d946f 100644 (file)
@@ -137,12 +137,9 @@ class OptionalDelegateField(DelegateField):
     no_change_choice = ('*', 'no change')
     to_field_name = None
 
-    def __init__(self, no_change_choice=None, *args, **kwargs):
-        self.filter = None
-        if (no_change_choice):
-            self.no_change_choice = no_change_choice
-        super(OptionalDelegateField, self). \
-            __init__(initial=self.no_change_choice[0], *args, **kwargs)
+    def __init__(self, *args, **kwargs):
+        super(OptionalDelegateField, self).__init__(
+            initial=self.no_change_choice[0], *args, **kwargs)
 
     def _get_choices(self):
         choices = list(
@@ -165,12 +162,9 @@ class OptionalModelChoiceField(forms.ModelChoiceField):
     no_change_choice = ('*', 'no change')
     to_field_name = None
 
-    def __init__(self, no_change_choice=None, *args, **kwargs):
-        self.filter = None
-        if (no_change_choice):
-            self.no_change_choice = no_change_choice
-        super(OptionalModelChoiceField, self). \
-            __init__(initial=self.no_change_choice[0], *args, **kwargs)
+    def __init__(self, *args, **kwargs):
+        super(OptionalModelChoiceField, self).__init__(
+            initial=self.no_change_choice[0], *args, **kwargs)
 
     def _get_choices(self):
         # _get_choices queries the database, which can fail if the db