Quote arguments, just in case there's a space in a pathname.

(Diagnosed by pabelanger on #asterisk-dev, fixed by me.)

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@299989 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/apps/app_voicemail.c b/apps/app_voicemail.c
index 68f80b8874734fde32b1698b5b2a9e404e0c09fd..26f0c77bcfea5931c57882de54bf98c7513bec44 100644 (file)
--- a/apps/app_voicemail.c
+++ b/apps/app_voicemail.c
@@ -12382,7 +12382,7 @@ AST_TEST_DEFINE(test_voicemail_msgcount)
        }
 
        /* Make sure the original path was completely empty */
-       snprintf(syscmd, sizeof(syscmd), "rm -rf %s%s/%s", VM_SPOOL_DIR, testcontext, testmailbox);
+       snprintf(syscmd, sizeof(syscmd), "rm -rf \"%s%s/%s\"", VM_SPOOL_DIR, testcontext, testmailbox);
        if ((syserr = ast_safe_system(syscmd))) {
                ast_test_status_update(test, "Unable to clear test directory: %s\n",
                        syserr > 0 ? strerror(syserr) : "unable to fork()");
@@ -12413,7 +12413,7 @@ AST_TEST_DEFINE(test_voicemail_msgcount)
                snprintf(tmp[i].txtfile, sizeof(tmp[i].txtfile), "%s.txt", tmp[i].file);
 
                if (ast_fileexists(origweasels, "gsm", "en") > 0) {
-                       snprintf(syscmd, sizeof(syscmd), "cp %s/sounds/en/%s.gsm %s/%s/%s/%s/msg0000.gsm", ast_config_AST_DATA_DIR, origweasels,
+                       snprintf(syscmd, sizeof(syscmd), "cp \"%s/sounds/en/%s.gsm\" \"%s/%s/%s/%s/msg0000.gsm\"", ast_config_AST_DATA_DIR, origweasels,
                                VM_SPOOL_DIR, testcontext, testmailbox, folders[i]);
                        if ((syserr = ast_safe_system(syscmd))) {
                                ast_test_status_update(test, "Unable to create test voicemail: %s\n",
@@ -12496,7 +12496,7 @@ AST_TEST_DEFINE(test_voicemail_msgcount)
 #endif
 
        /* And remove test directory */
-       snprintf(syscmd, sizeof(syscmd), "rm -rf %s%s/%s", VM_SPOOL_DIR, testcontext, testmailbox);
+       snprintf(syscmd, sizeof(syscmd), "rm -rf \"%s%s/%s\"", VM_SPOOL_DIR, testcontext, testmailbox);
        if ((syserr = ast_safe_system(syscmd))) {
                ast_test_status_update(test, "Unable to clear test directory: %s\n",
                        syserr > 0 ? strerror(syserr) : "unable to fork()");

diff --git a/main/file.c b/main/file.c
index 76212d093a377838f367f3589db9a6892ec319d5..a5c99d55a9d6e0cd9586e3c203c22c20c0c8c173 100644 (file)
--- a/main/file.c
+++ b/main/file.c
@@ -313,7 +313,7 @@ static void filestream_destructor(void *arg)
                        size = strlen(f->filename) + strlen(f->realfilename) + 15;
                        cmd = alloca(size);
                        memset(cmd,0,size);
-                       snprintf(cmd,size,"/bin/mv -f %s %s",f->filename,f->realfilename);
+                       snprintf(cmd, size, "/bin/mv -f \"%s\" \"%s\"", f->filename, f->realfilename);
                        ast_safe_system(cmd);
        }