s3: smbd: Reformat code in SEC_FLAG_SYSTEM_SECURITY check in create_file_unixpath().

No logic change but uses modern formatting and will
make it easier to add another clause in the next commit.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index 9beabb6a109a1b136379818fa3c56049c4232464..d4c77602daf0151c0beac1a37654a358ec693cd0 100644 (file)
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -5420,14 +5420,18 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
                }
        }
 
-       if ((access_mask & SEC_FLAG_SYSTEM_SECURITY) &&
-                       !security_token_has_privilege(get_current_nttok(conn),
-                                       SEC_PRIV_SECURITY)) {
-               DEBUG(10, ("create_file_unixpath: open on %s "
-                       "failed - SEC_FLAG_SYSTEM_SECURITY denied.\n",
-                       smb_fname_str_dbg(smb_fname)));
-               status = NT_STATUS_PRIVILEGE_NOT_HELD;
-               goto fail;
+       if (access_mask & SEC_FLAG_SYSTEM_SECURITY) {
+               bool ok;
+
+               ok = security_token_has_privilege(get_current_nttok(conn),
+                                                 SEC_PRIV_SECURITY);
+               if (!ok) {
+                       DBG_DEBUG("open on %s failed - "
+                               "SEC_FLAG_SYSTEM_SECURITY denied.\n",
+                               smb_fname_str_dbg(smb_fname));
+                       status = NT_STATUS_PRIVILEGE_NOT_HELD;
+                       goto fail;
+               }
        }
 
        /*