]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
hw/net/can: Remove redundant status bit setting in can_sja1000
authorSillyZ <1357816113@qq.com>
Tue, 16 Sep 2025 08:10:09 +0000 (16:10 +0800)
committerMichael Tokarev <mjt@tls.msk.ru>
Sun, 5 Oct 2025 06:46:06 +0000 (09:46 +0300)
In PeliCAN mode reception, the RBS (Receive Buffer Status) bit
is set twice at line 842 and 845 with identical operations:
  s->status_pel |= 0x01;
  s->status_pel |= (1 << 0);

Between these two operations, only interrupt_pel is modified and
status_pel bit 4 is cleared, neither affecting bit 0. The second
operation is redundant.

This cleanup aligns PeliCAN mode with BasicCAN mode, which correctly
sets this bit only once (line 883).

Signed-off-by: SillyZ <1357816113@qq.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/net/can/can_sja1000.c

index 5b6ba9df6c42f67a5fed4d7b8904247151ebf783..6b08e977a1d79c4295c025fecaf34740842e2667 100644 (file)
@@ -842,7 +842,6 @@ ssize_t can_sja_receive(CanBusClientState *client, const qemu_can_frame *frames,
         s->status_pel |= 0x01; /* Set the Receive Buffer Status. DS-p23 */
         s->interrupt_pel |= 0x01;
         s->status_pel &= ~(1 << 4);
-        s->status_pel |= (1 << 0);
         can_sja_update_pel_irq(s);
     } else { /* BasicCAN mode */