]> git.ipfire.org Git - thirdparty/patchwork.git/commitdiff
api: do not fetch every patch in a patch detail view 404 (v2)
authorStephen Finucane <stephen@that.guru>
Wed, 24 Feb 2021 15:08:45 +0000 (15:08 +0000)
committerStephen Finucane <stephen@that.guru>
Wed, 24 Feb 2021 15:29:50 +0000 (15:29 +0000)
Commit 08c5856 fixed an issue whereby a 404 on the aforementioned URL
could result in a large DB query due to DRF attempting to populate the
'related' list box with all patches on the instance. That was
accidentally reverted in commit fe07f30. "Unrevert" this change.

Signed-off-by: Stephen Finucane <stephen@that.guru>
Fixes: fe07f30 ("Remove 'PatchRelationSerializer'")
Closes: #397
(cherry picked from commit 79700f321335a2d7c649eb03932797af521942a0)

patchwork/api/patch.py

index f6cb276d7007dc21fe79059f6686b7181a03907f..9d222754412ed2919b909191f6b1b610b5df1e7b 100644 (file)
@@ -84,7 +84,8 @@ class PatchListSerializer(BaseHyperlinkedModelSerializer):
     checks = SerializerMethodField()
     tags = SerializerMethodField()
     related = PatchSerializer(
-        source='related.patches', many=True, default=[])
+        source='related.patches', many=True, default=[],
+        style={'base_template': 'input.html'})
 
     def get_web_url(self, instance):
         request = self.context.get('request')