]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: rkisp1: Fix memory leaks in rkisp1_isp_unregister()
authorTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Wed, 22 Nov 2023 15:50:08 +0000 (16:50 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Jan 2024 23:45:03 +0000 (15:45 -0800)
[ Upstream commit 688f3af3c354adc19b78d352c8c7b2006f993f2d ]

Add missing call to v4l2_subdev_cleanup() to fix memory leak.

Link: https://lore.kernel.org/r/20231122-rkisp-fixes-v2-2-78bfb63cdcf8@ideasonboard.com
Fixes: 2cce0a369dbd ("media: rkisp1: isp: Use V4L2 subdev active state")
Reviewed-by: Tommaso Merciai <tomm.merciai@gmail.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c

index 88ca8b2283b7f067069535b2bc7aabc4e6d0c0be..45d1ab96fc6e753276c5a4f7daf6ee020b61ec53 100644 (file)
@@ -933,6 +933,7 @@ void rkisp1_isp_unregister(struct rkisp1_device *rkisp1)
                return;
 
        v4l2_device_unregister_subdev(&isp->sd);
+       v4l2_subdev_cleanup(&isp->sd);
        media_entity_cleanup(&isp->sd.entity);
 }