]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: c8sectpfe: Call of_node_put(i2c_bus) only once in c8sectpfe_probe()
authorMarkus Elfring <elfring@users.sourceforge.net>
Fri, 4 Oct 2024 13:50:15 +0000 (15:50 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Jun 2025 12:42:02 +0000 (14:42 +0200)
[ Upstream commit b773530a34df0687020520015057075f8b7b4ac4 ]

An of_node_put(i2c_bus) call was immediately used after a pointer check
for an of_find_i2c_adapter_by_node() call in this function implementation.
Thus call such a function only once instead directly before the check.

This issue was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c

index 5dc1f908b49bd6d07fecb4fa13d3caa5cbfd5c6c..9aa484126a0dd6e1e43b7dd1e7a3a35f716303e4 100644 (file)
@@ -806,13 +806,12 @@ static int c8sectpfe_probe(struct platform_device *pdev)
                }
                tsin->i2c_adapter =
                        of_find_i2c_adapter_by_node(i2c_bus);
+               of_node_put(i2c_bus);
                if (!tsin->i2c_adapter) {
                        dev_err(&pdev->dev, "No i2c adapter found\n");
-                       of_node_put(i2c_bus);
                        ret = -ENODEV;
                        goto err_node_put;
                }
-               of_node_put(i2c_bus);
 
                /* Acquire reset GPIO and activate it */
                tsin->rst_gpio = devm_fwnode_gpiod_get(dev,